Make jmh params configurable via command line args#8305
Open
jack-berg wants to merge 3 commits intoopen-telemetry:mainfrom
Open
Make jmh params configurable via command line args#8305jack-berg wants to merge 3 commits intoopen-telemetry:mainfrom
jack-berg wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8305 +/- ##
=========================================
Coverage 90.25% 90.26%
- Complexity 7687 7688 +1
=========================================
Files 850 850
Lines 23198 23198
Branches 2354 2354
=========================================
+ Hits 20938 20940 +2
+ Misses 1532 1531 -1
+ Partials 728 727 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y-java into configurable-jmh-params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarks we run in benchmark.yml use shared bare metal runners, so we want to be judicious with how much time our runs take.
Local runs don't have the same constraints, and it can be quite useful to run with more forks, more time, or more iterations to reduce variance.
This makes such customization easy by adding parameters.
For example: